Bug fix for compistion on member and media give 404#15017
Bug fix for compistion on member and media give 404#15017emmagarland merged 1 commit intoumbraco:contribfrom
Conversation
|
Hi there @rammi987, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
|
Thanks @rammi987 for this fix! A member of the core collaborators team will have a look at it soon 😁 |
|
Hi @rammi987, thanks so much for your pull request to fix the issue of compositions with media types and member types returning a 404 when linking to them (#15009). I've just replicated this and can confirm that your fix resolves it! I will merge this PR. The only other minor suggestion I might have had is to refactor the method into a shared method (since it is very similar in two places), but this isn't vital. It has now been successfully merged 🙌 It is targeted for release Finally, I've marked this PR with the Best wishes Emma |
Prerequisites
If there's an existing issue for this PR then this fixes
#15009
Description
The solution is simple and work without any compromise made, the code is taken from what is allerede done, in the code here:
Umbraco-CMS/src/Umbraco.Web.UI.Client/src/views/dataTypes/views/datatype.info.controller.js
Line 74 in f8b66aa